search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
6 stars 1 forks source link

CPF004.002 CPU with load runs on expected frequency (Windows 11) requires sshpass on the machine running test #234

Closed pkubaj closed 5 days ago

pkubaj commented 3 months ago

Device

VP4670 v2

RTE version

1.1.0

Affected component(s) or functionality

No response

Brief summary

sshpass is not installed but required

How reproducible

100%

How to reproduce

robot -b command_log.txt -v snipeit:no -L TRACE -v rte_ip:192.168.10.14 -v device_ip:192.168.10.53 -v config:protectli-vp4670 -t "CPF004.002*" dasharo-performance/cpu-frequency.robot

Expected behavior

Test should pass

Actual behavior

CPF004.002 CPU with load runs on expected frequency (Windows 11) :... | FAIL |                 
'/bin/sh: 1: sshpass: not found' should be empty.

Link to screenshots or logs

command_log.txt

Additional context

No response

Solutions you've tried

No response

pkubaj commented 3 months ago

Nevermind, it needed to be installed on the host that executed the test.

macpijan commented 3 months ago

It is a bit weird requirement. I suggest to keep this open, with the goal of removing this dependency - maybe rename issue in this direction.

I do not see why we would need it, we should use RF SSH library. It is likely some poor implementation we should improve.

macpijan commented 5 days ago

Integrated into: https://github.com/Dasharo/open-source-firmware-validation/pull/361