search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
6 stars 1 forks source link

Fix cbmem003.001 #240

Closed macpijan closed 3 months ago

macpijan commented 3 months ago

Reboot should be called in each iteration, not at the end of the test. Fixes: https://github.com/Dasharo/open-source-firmware-validation/issues/238

macpijan commented 3 months ago

Example result:

==============================================================================
Boot-Time-Measure                                                             
==============================================================================
CBMEM003.001 Serial boot time measure: coreboot booting time after... ...

.(0) Boot time: 1.878199 s)
(1) Boot time: 1.833479 s)
(2) Boot time: 1.834442 s)
(3) Boot time: 1.835386 s)
(4) Boot time: 1.834426 s)
..
Coreboot average booting time: 1.8431864 s

CBMEM003.001 Serial boot time measure: coreboot booting time after... | PASS |
------------------------------------------------------------------------------
Boot-Time-Measure                                                     | PASS |
1 test, 1 passed, 0 failed
==============================================================================
macpijan commented 3 months ago

Please see the commit msg of b40f6e69203934e3bc70aeba2ec605e8018a6395 for explanation.

Example failure was:

59 min.
Current temperature: 76.0°C

 ----------------------------------------------------------------
60 min.
Current temperature: 61.0[1]+  Done                    stress-ng --cpu $(nproc) --timeout 60m &> /dev/null
°C
CPT002.001 CPU temperature after stress test (Ubuntu 22.04) :: Thi... | FAIL |
Evaluating expression '61.0[1]+  Done                    stress-ng --cpu $(nproc) --timeout 60m &> /dev/null
 < 82' failed: SyntaxError: invalid decimal literal (<string>, line 1)