search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
8 stars 1 forks source link

Introduce headset flag #269

Closed macpijan closed 4 months ago

macpijan commented 5 months ago

The "AUD004.001 External headset recognition (Ubuntu 20.04)" is always executed if audio is tested. But some platforms (like the VP2410) do not have audio jacks for headset to be tested. So running them makes no sense.

We can introduce a new flag, and run these only when headset can be connected to the platform.

PLangowski commented 5 months ago

@macpijan Could you list the platforms that do/do not support external headsets so that I can modify their configs? I'm assuming that most of them do have jack input, so maybe setting the default flag value to true is a good idea, wdyt?

PLangowski commented 5 months ago

As of now, I added the flag, which is false by default. I set it to true for some of the platforms. The test passes for MSI PRO Z690-A DDR4, for which the flag is set to true. It also skips the test for Protectli VP4630, where the flag is false.

macpijan commented 5 months ago

Could you list the platforms that do/do not support external headsets so that I can modify their configs

I am sure you can figure it out by yourself. If in trouble, pleas ask specific questions.

https://eu.protectli.com/product-comparison/

PLangowski commented 5 months ago

@macpijan I checked the platforms and modified the configs accordingly.

macpijan commented 4 months ago

Fixed in: https://github.com/Dasharo/open-source-firmware-validation/pull/277