search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
8 stars 1 forks source link

Temperature detection and reporting should be reworked #281

Closed pkubaj closed 1 month ago

pkubaj commented 5 months ago

Device

Any

RTE version

1.10

Affected component(s) or functionality

No response

Brief summary

Temperature detection and reporting should be reworked

How reproducible

No response

How to reproduce

Try running CPT tests.

Expected behavior

CPT tests should not return failure when the temperature is almost all the time ok.

Actual behavior

CPT tests detect and report the current temperature and return fail when it's too high even when there are only temporary spikes.

Link to screenshots or logs

I don't have logs.

Additional context

No response

Solutions you've tried

No response

tym2k1 commented 2 months ago

Already addressed by https://github.com/Dasharo/open-source-firmware-validation/commit/9b50c95d93ac9b0f8501080044c5a4930cb8f2fa

philipandag commented 1 month ago

This issue is solved in current develop branch. The test only fails if the average temperature over all the measurements exceeds the max acceptable value. Additionally the tests also presents the lowest, highest and the standard deviation of the measured temperatures. Tested on an NV40MB normally and with simulated temp values to check the fail condition.

When testing I have noticed an error in calculating the average which will only appear when the measurement interval is different than 1. https://github.com/Dasharo/open-source-firmware-validation/pull/481