search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
6 stars 1 forks source link

Added test to verify if network boot uses https:// and not http:// #300

Closed JanPrusinowski closed 2 weeks ago

JanPrusinowski commented 1 month ago

Added test to verify if network boot uses https:// and not http:// Fixes: https://github.com/Dasharo/open-source-firmware-validation/issues/200

macpijan commented 1 month ago

@JanPrusinowski This commit name does not follow our guidelines. Please see other commit names in this repo.

I would expect something like: network-boot.robot: PXE007.001 verify https not http

JanPrusinowski commented 1 month ago

@macpijan commit message fixed.

macpijan commented 1 month ago

Hmm one more thing @JanPrusinowski . I can see changes in the sonoff-rest-api submodule, they should rather not belong here. They might be caused if you have switched branches and commited using git add -A. It is advised to add individual files via git add <file> or even individual changes via git add -p to avoid such problems.