Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
6 stars 1 forks source link

Move default values for login and password from PiKVM keywords to seprate keys #303

Open JanPrusinowski opened 1 month ago

JanPrusinowski commented 1 month ago

Test environment version

Dasharo version (if applicable)

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

pikvm-rest-api

Brief summary PiKVM uses values stored as defaults in keywords to login to the device.

Additional context /pikvm-rest-api/pikvm-comm.robot

Write Bare PiKVM
    [Documentation]    Keyword for PiKVM writing bare into Terminal.
    ...    WARNING: Supports only small characters.
    ...    text - text to be written,
    ...    pikvm_ip - IP of the piKVM to send key input,
    ...    login - piKVM login,
    ...    password - piKVM password
    [Arguments]    ${text}    ${login}=admin    ${password}=admin
    Write Text PiKVM    ${text}    ${PIKVM_IP}    ${login}    ${password}

Keywords use default '=admin' values for login and password - this makes finding of this key very hard.

Refactor the code by creating a new key stored with other keys and link it to this keywords.

This issue may apply to other login methods too.