remove "boot from usb" kw

[PLangowski]

@macpijan I tested this on MSI. I assumed that the tests needed USB boot when they used the keyword, but you're right.

The following tests used the Boot from USB option:

• Test cases in dasharo-compatibility/usb-boot.robot. These obv. need to boot from USB.
• dasharo-compatibility/coreboot-fan-control.robot: These may not need USB boot, as they just want to boot Debian.
• dasharo-compatibility/flash-write-protection.robot: Same as above.

So perhaps in the last two suites the keywords should be replaced with Boot System Or From Connected Disk debian, what do you think?

[macpijan]

 So perhaps in the last two suites the keywords should be replaced with  Boot System Or From Connected Disk     debian, what do you think?

Sounds fine, maybe even Ubuntu as this is what we mostly test. Which platform supports these tests? IIRC it could have been kgpe only. If this is the case, we might not care that much as it is not really supported platform.

[PLangowski]

It seems that no platform config supports the fan control tests:

platform-configs/raptor-cs_talos2.robot
54:${COREBOOT_FAN_CONTROL_SUPPORT}=                    ${FALSE}

platform-configs/rpi-3b.robot
68:${COREBOOT_FAN_CONTROL_SUPPORT}=                    ${FALSE}

platform-configs/include/default.robot
92:${COREBOOT_FAN_CONTROL_SUPPORT}=                    ${FALSE}

platform-configs/qemu.robot
98:${COREBOOT_FAN_CONTROL_SUPPORT}=                    ${FALSE}

dasharo-compatibility/coreboot-fan-control.robot
24:...                     Skip If    not ${COREBOOT_FAN_CONTROL_SUPPORT}    coreboot fan control not supported

As for the write protection suite, it seems that PCEngines platforms support it

rg "HARDWARE_WP_SUPPORT"
dasharo-compatibility/flash-write-protection.robot
24:...                     Skip If    not ${HARDWARE_WP_SUPPORT}    Flash protection tests not supported

platform-configs/include/default.robot
123:${HARDWARE_WP_SUPPORT}=                             ${FALSE}

platform-configs/raptor-cs_talos2.robot
87:${HARDWARE_WP_SUPPORT}=                             ${FALSE}

platform-configs/include/pcengines.robot
69:${HARDWARE_WP_SUPPORT}=                     ${TRUE}

platform-configs/rpi-3b.robot
101:${HARDWARE_WP_SUPPORT}=                             ${FALSE}

platform-configs/qemu.robot
131:${HARDWARE_WP_SUPPORT}=                             ${FALSE}

I can change the OS to Ubuntu if you think that's a good idea.

EDIT: Done 8a9476d