platform-configs/rpi-3b.robot: config has values that don't make sense

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results

Apache License 2.0

8 stars 1 forks source link

platform-configs/rpi-3b.robot: config has values that don't make sense #33

Open WiktorG351 opened 11 months ago

WiktorG351 commented 11 months ago

the config has values that don't make sense, for example here:

# Regression test flags
# Test module: dasharo-compatibility
${BASE_PORT_BOOTBLOCK_SUPPORT}=                     ${FALSE}
${BASE_PORT_ROMSTAGE_SUPPORT}=                      ${FALSE}
${BASE_PORT_POSTCAR_SUPPORT}=                       ${FALSE}
${BASE_PORT_RAMSTAGE_SUPPORT}=                      ${FALSE}

the values that are not used should be removed.

artur-rs commented 11 months ago

We should make a standard approach to the configs on different environments like Yocto vs. coreboot etc. Removing every unnecessary variable is the easiest approach, but TBD if it's the best. The document explaining which flag must be filled in based on the used firmware/software components/connected hardware would be a great addition.