Wrong PASS criteria in Verified Boot

filipleple commented 2 months ago

Device

any

RTE version

any

OSFV version

a6145514ee111e264aef873551b2bbc473b9626a

Affected component(s) or functionality

dasharo-security/verified-boot.robot

Brief summary

Verified Boot suite fails due to wrong assumptions

How reproducible

100%

How to reproduce

Proceed with VBO001.001 ... VBO003.001 - additionally flash the RW_SECTION_B as well
Observe the recovery popup

Expected behavior

It should PASS when a recovery popup appears after resigning FW with own keys and flashing to RW_SECTION_* - IIRC that's how verified boot should work, since the keys will be different than the initial build ones

Actual behavior

It FAILS - expects booting from Slot A

Link to screenshots or logs

Additional context

No response

Solutions you've tried

No response

macpijan commented 2 months ago

@BeataZdunczyk adding vboot label

BeataZdunczyk commented 2 months ago

Isn't this fixed, @JanPrusinowski? Please link the PR that fixes this issue and share the platform on which it was successfully tested.

JanPrusinowski commented 2 months ago

I was unable to reproduce this bug. @filipleple could you provide more info about the platform, and which particular test is the issue?

filipleple commented 2 months ago

@JanPrusinowski it was the NovaCustom V560TU, tests VBO001.001 ... VBO003.001. It's important to flash both RW_SECTION_A and B, and not full BIOS region

EDIT: These three are manual only tests, they're not automated. Now I'm not entirely sure if we're tracking all test issues here, including manual ones

Dasharo / open-source-firmware-validation