Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
7 stars 1 forks source link

Dasharo Performance: CPU temperature measure test gets wrong value #42

Open johanes2115 opened 11 months ago

johanes2115 commented 11 months ago

Both test cases return:

56.0Â' cannot be converted to a floating point number: ValueError: could not convert string to float: '56.0Â'

Tested on Novacustom nv41 ADL. Branch novacustom-wip.

Psotas commented 10 months ago

cpu-temperature_log.zip Same problem on MSI® PRO Z690-A DDR4 Dasharo v1.1.3

Psotas commented 6 months ago

This test needs to be improved and tested on all platforms. Currently, when someone corrects this test for a given platform, it ruins it for another.

VP4650:

'100.0°C)
' cannot be converted to a floating point number: ValueError: could not convert string to float: '100.0°C)\n'
macpijan commented 1 month ago

We have something here: https://github.com/Dasharo/open-source-firmware-validation/pull/341

Could be verified on a few different platforms to ensure the proposed solution works fine @BeataZdunczyk