pietrushnic
commented
1 week ago @macpijan I wonder how far I should go with that, now results are as follows:
% ./scripts/ci/qemu-self-test-seabios.sh
==============================================================================
Setup-And-Boot-Seabios :: This suite verifies the correct operation of keyw...
==============================================================================
Enter Boot Menu SeaBIOS :: Test Enter Boot Menu kwd | PASS |
------------------------------------------------------------------------------
Enter Boot Menu SeaBIOS And Return Construction :: Test Enter Boot... | PASS |
------------------------------------------------------------------------------
Enter sortbootorder :: Test Enter sortbootorder kwd | PASS |
------------------------------------------------------------------------------
Enter TPM Configuration :: Test Enter TPM Configuration kwd | PASS |
------------------------------------------------------------------------------
Enter iPXE :: Test Enter iPXE kwd | FAIL |
No match found for 'autoboot' in 10 seconds. Output:
------------------------------------------------------------------------------
Setup-And-Boot-Seabios :: This suite verifies the correct operatio... | FAIL |
5 tests, 4 passed, 1 failed
==============================================================================
Output: /home/user/src/3mdeb/dasharo/open-source-firmware-validation/logs/2024.11.12_14.29.14/setup-and-boot-seabios/output.xml
Log: /home/user/src/3mdeb/dasharo/open-source-firmware-validation/logs/2024.11.12_14.29.14/setup-and-boot-seabios/log.html
Report: /home/user/src/3mdeb/dasharo/open-source-firmware-validation/logs/2024.11.12_14.29.14/setup-and-boot-seabios/report.html
zsh: exit 1 ./scripts/ci/qemu-self-test-seabios.shOf course, I can satisfy all the checks despite the self-test change, and if my approach is correct, I would probably need your approval.
Regarding the SeaBIOS self-test, my concern is that I'm entering the land of testing sortbootorder; some tests exist in the legacy framework, and I could start porting those, but then the question arises: what is the difference between the keyword that should be tested and test itself. I think we should validate iPXE and network booting comprehensively, but to enter iPXE you need to enable network, which means you have to teach OSFV how to walk into sortbootorder (already done ) and change some option (probably done in legacy test suite).
Please let me know how to split those changes to merge most of them. The results are far from production, but I'm working on fixes.
The two most important fixes support for flash in sortbootorder and figuring out how to run iPXE in QEMU, so QEMU would not use OptionROM, but SeaBIOS will load builtin one.