search

Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
9 stars 2 forks source link

540 reset to defaults restore serial #601

Open philipandag opened 3 days ago

macpijan commented 2 hours ago

@philipandag please fix pre-commit prior review request

Do you have it installed locally in repo?

philipandag commented 1 hour ago

@philipandag please fix pre-commit prior review request

Do you have it installed locally in repo?

This time I had it installed. There's a weird behaviour of the pre-commit in this repo right now:

/code/lib/bios/menus.robot:582:1 [W] 0501 Keyword 'Boot System Or From Connected Disk' is too long (52/50) (too-long-keyword)

That's not a part of my changes, thus the local pre-commit does not see any issues as it only checks the modified files. And the keyword is not actually 52 characters long.

I have encountered this problem in another PR and @mkopec helped with it by giving an exception for this keyword to pre-commit. https://github.com/Dasharo/open-source-firmware-validation/commit/21b5ce1e97576c7f28d3ef86c7e3837438835fe7 I believe rebasing this PR onto develop will fix this issue.

macpijan commented 1 hour ago

Very weird... let's try to rebase then.