search

Dasharo / twpm-docs

Trustworthy Platform Module (TwPM) documentation
https://twpm.dasharo.com
5 stars 0 forks source link

requirements.md: Initial commit, for hardware requirements #4

Closed 3mdeb-karolzmyslowski closed 1 year ago

3mdeb-karolzmyslowski commented 1 year ago

Requirements, collect, analysis

macpijan commented 1 year ago

@3mdeb-karolzmyslowski I still see pre-commit is failing - why?

3mdeb-karolzmyslowski commented 1 year ago

@macpijan wrote: I still see pre-commit is failing - why? Markdown linter points lines with reference/link to documentation. I'm solving this problem.

macpijan commented 1 year ago

@3mdeb-karolzmyslowski There are a lot more errors reported here: https://results.pre-commit.ci/run/github/583002094/1677692849.vJaD6YPcT0ir3kVL73Y9Hg

Some of them could be fixed automatically by the tool. Which makes me think, you have not installed pre-commit locally.

pietrushnic commented 1 year ago

@macpijan I think that methodology used in Fobnail: https://fobnail.3mdeb.com/minimal-os-for-fobnail/#summary as well as in other projects, was quite good, why not use it here again?

macpijan commented 1 year ago

@3mdeb-karolzmyslowski This comment was ignored by you: https://github.com/Dasharo/twpm-docs/pull/4#pullrequestreview-1356963346

3mdeb-karolzmyslowski commented 1 year ago

@macpijan wrote:

@3mdeb-karolzmyslowski This comment was ignored by you: #4 (review)

Actually, I have no clue, how could I issue into the document. I know, it's hardware requirement. I've missed it, so I have to put into requirement, but I don't have reference document, to point it.

krystian-hebel commented 1 year ago

@macpijan wrote:

@3mdeb-karolzmyslowski This comment was ignored by you: #4 (review)

Actually, I have no clue, how could I issue into the document. I know, it's hardware requirement. I've missed it, so I have to put into requirement, but I don't have reference document, to point it.

There is no direct requirement for this in any specification. Code size depends on amount of algorithms we want to put into the implementation mostly, and it may change in later revisions of the specification, probably towards more so I think 1MB is safer to assume. Same goes for RAM, but this in addition depends on architecture - e.g. number of available registers or calling convention may heavily impact the amount that is required.

I think doing a binary good/bad decision may be dangerous. The values that Artur mentioned may be treated as absolute minimums, but for choosing the hardware it would be safer to have soft requirements for more memory. We don't want to create TPM that would be outdated by the time we're finished with this project.

3mdeb-karolzmyslowski commented 1 year ago

@macpijan @miczyg1 @krystian-hebel @arturkow2000 @pietrushnic Feel free to review my document. I've organized description the chips/boards, add functionality matrix, against requirements. There is need to alter the factors/weights for the boards.

macpijan commented 1 year ago

This shall be replaced with: https://github.com/Dasharo/twpm-docs/pull/8