search

DashboardHub / PipelineDashboard

Dashboard for your Deployment pipeline https://dashboardhub.io/
https://pipeline.dashboardhub.io/
GNU General Public License v3.0
152 stars 42 forks source link

fix(repository): #1603 delete repo subcollection #1604

Closed kykyk closed 4 years ago

kykyk commented 4 years ago

Done:

eddiejaoude commented 4 years ago

Sorry for my slow reply.

After testing it appears that the documents in the sub collection statuses do get deleted but the sub collection itself remains (although empty). I think the empty sub collection needs to also needs to get deleted

Screenshot 2019-11-18 07 58 48
kykyk commented 4 years ago

Sorry for my slow reply.

After testing it appears that the documents in the sub collection statuses do get deleted but the sub collection itself remains (although empty). I think the empty sub collection needs to also needs to get deleted

Screenshot 2019-11-18 07 58 48

Could you provide me a chain of action you did for reproducing this bug?

eddiejaoude commented 4 years ago

Could you provide me a chain of action you did for reproducing this bug?

Sure...

  1. create project
  2. add repo to project
  3. create PR in repo on GitHub (statuses sub collection now has an entry)
  4. delete project

All documents in the statuses sub collection were deleted correctly but the sub collection itself remains

kykyk commented 4 years ago

I checked a problem It is not bug, the empty subcollection in firebase automatically delete through sometime