feat(functions): #1556 saved historic builds

DashboardHub / PipelineDashboard

Dashboard for your Deployment pipeline https://dashboardhub.io/

https://pipeline.dashboardhub.io/

GNU General Public License v3.0

152 stars 114 forks source link

feat(functions): #1556 saved historic builds #1642

Closed webkhushboo closed 4 years ago

webkhushboo commented 4 years ago

closes #1556

Notes

A summary of what was achieved in this PR

[ ] API: Save pull request statuses data
[ ] API: Delete statuses collection when project delete
[ ] API: Delete statuses collection when repository update
[ ] API: When webhook calls it update the historic build time

eddiejaoude commented 4 years ago

Can you add a screenshot of the data saved in the DB?

I seem to have missing data in the tests I did...

CI builds

Statuses is an empty array

webkhushboo commented 4 years ago

@eddiejaoude

Please see the below screenshot with data.

eddiejaoude commented 4 years ago

It works for Circle CI and Travis CI but not GitHub actions. We can look into GitHub actions in a new PR.

See data from Travis CI

However, when the PR is closed the statuses data remains, this sub collection will get very, so the document in the sub collection for that PR should get deleted when the webhook for closing that PR comes in (sorry this was not included in the original information)

webkhushboo commented 4 years ago

@eddiejaoude We will be showing the historic data for build statuses in graphs so we need this data and we can't delete it.

eddiejaoude commented 4 years ago

Yes you are right 👍