search

Dashticz / dashticz_v2

Alternative dashboard for Domoticz
107 stars 59 forks source link

Fixed spotify blocking loading of devices #304

Closed Ectholian closed 6 years ago

Ectholian commented 6 years ago

Quickfix for the bug where the devices didn't load when the spotify block was included. Better solution would be to make each js-plugin a js-module and dont expose the private members to the global scope.

robgeerts commented 6 years ago

Thanks for your contribution!

robgeerts commented 6 years ago

By the way, this was one of the bugs I couldnt find..... So multiple thanks to you!

Ectholian commented 6 years ago

No problem. I didn't had time to implement a better fix, but working on that. Actually it was nasty to find because there is no real exception :) but i saw that empty div's got rendered for each device and when i saw the getDevices method on the global scope, it became math :)