Closed Ectholian closed 6 years ago
will test right away!
Squashed one bug... It called getLoginURL where it needed to call _getLoginURL
Darnit, i think i messed a file up. I fixed that already :) The getracklist function has the same problem.
And the _getTracks too. Also, the last line of the module: }() has to be ended with a semicolon ;
ok, hold on
I think Im gonna try this plugin you mentioned: https://github.com/JMPerez/spotify-web-api-js
Might come in handy. Maybe my first quickfix is fine for the stable branch and for the beta this library might be good combined with this 'scoping' trick. I also see some javascript errors in the console when for example selecting a device without a playlist on it; this could potentially break the rest of javascript execution.
Ok, I will leave the original spotify.js in tact and work on another file while it is not finished ;)
Please test and review, I think this way the plugins are less sensitive for global scope bugs like the getDevices function.