search

Dashticz / dashticz_v2

Alternative dashboard for Domoticz
107 stars 59 forks source link

Saving the configuration via the screen Dashticz is putting single quotes around boolean configs #310

Open ericvb opened 6 years ago

ericvb commented 6 years ago

When I take an old configuration file, I find the Boolean settings defined like this: config['last_update'] = '0'

In the latest version, I had to change manually all Boolean settings to: config['last_update'] = 0 to get it working.

When saving the settings via the screen, the saving code is setting again everywhere single quotes around the Booleans, causing them to not work again

ericvb commented 6 years ago

Extra information: only 'false' Boolean settings are getting the single quotes...

DewGew commented 6 years ago

Is this issue fixed?

lokonli commented 6 years ago

Yes. Issue can be closed.

aiolos commented 6 years ago

The code from #328 breaks Dashticz on at least iOS10 on an iPad. (but maybe this topic on the forum is also related)

I commented the code in PR #344, I think it is related to the use of the Number() function, which is too new for the used browser versions. @lokonli can you solve this another way? There are also some other users using older browsers (which had issues before when using new JavaScript functionality).

aiolos commented 6 years ago

With #344 now closed, I think this can be closed too