Dashticz / dashticz_v2

Alternative dashboard for Domoticz
107 stars 62 forks source link

Bug in getDimmerBlock #323

Closed lokonli closed 6 years ago

lokonli commented 6 years ago

I think there is a bug in getDimmerBlock: (main.js)

In case of a RGB device a RGB slider is added which leads to adding elements to the DOM for every call of getDevices, resulting in bad performance after a while.

This can be temporarily fixed by adding the line 'return false;' as first line in the function isRGBDeviceAndEnabled, but this removes the RGB behavior of course.

I will create a patch and PR as temporary fix: you can decide to integrate it in main/beta. A real solution probably is needed as well.

lokonli commented 6 years ago

Solved in beta.