Closed czacha338 closed 6 years ago
Hi Adrian, thanks for your efforts. BUT, please download latest beta and add your additions to that version. For example, the version.js is older (you used a version from master-branch?) Also, theres a mistake in settings.js, you are setting the regular wunderground-vars if owm-vars are undefined...
I'm closing this PR, please add a new one..
Click on the "Fork" button and you get a copy of the repository in your account..
Let me do this when I will be back from work :]
I had already created a fork, switch to beta branch and done the changes, make a commit and push. For some reasons this version.js came with old git version. I have deleted the whole fork and when I will be back at home I will do this again. Making first steps in git can be tricky...
Double check you're working in the test-branch ;)
Hi Rob,
just short question, maybe it is worth to have only one definition of weather variables in settings.js? I think that when user will choose that would like Fahrenheit it supposed to be considered in both weather forecasts? Just to reduce config options :) Or do you mean something else?
Best regards,
Adrian
Hi,
New users, which can not get API key for Wunderground have to leave without weather forcast. I have found 2 solution, for them:
1. Solution:
Put into frame weather forecast from Forecast.io, example of url: http://forecast.io/embed/#lat=49.9816&lon=9.0865&name=Mainaschaff&color=#00aaff&font=Helvetica&fontcolor=#ffffff&units=si&text-color=#fff%22
2. Solution:
I have developed a java script which is using an api provided from https://openweathermap.org/ .
This openweathermap has only one disadvantage, if someone would like to get a daily weather forecast needs to pay. I prefer to use hourly forecast anyway, because it is more precise and easily to predict weather for next few hours. :) The whole javascript is compatible with your configuration, so it is easy to use it. I am not sure if user can use both weather forecasts, maybe then some changes in names of functions will be necessary. Unfortunately I cannot test it... Below how it look like:![openweather](https://user-images.githubusercontent.com/40031567/41510354-64b4c1d8-7263-11e8-8817-bb0a905aa031.PNG)
And right now changes in code (if you will like it you can marge to your branch): js/blocks.js
js/main.js
js/settings.js
js/weather_owm.js weather_owm.zip
And configuration in CONFIG.js: //weather new OWM
Best regards,
Adrian
PS. I hope that right now it looks like a real pull request :)