search

DassHydro / smash

An open source, Python library interfacing the Fortran Spatially distributed Modelling and ASsimilation for Hydrology platform.
https://smash.recover.inrae.fr/
GNU General Public License v3.0
12 stars 6 forks source link

Parameter order in scaling layer of net #168

Closed nghi-truyen closed 6 months ago

nghi-truyen commented 6 months ago

The issue arises in the scaling layer of net when the keys of bounds are not in the same order as parameters when the bounds argument is specified within the optimize_options. This discrepancy occurs because the standardize function for net does not appropriately adjust the order of bounds according to the order of parameters. For instance:

model.optimize("ann", optimize_options={"bounds": {"kexc": (-5, 20)})

So the argument bounds is standardized but does not remain the order following parameters by the stadardize_optimize_options_bounds function.

nghi-truyen commented 6 months ago

This issue would resolved by the PR #169.