ENH/MAINT: enhance metric computation method

DassHydro / smash

An open source, Python library interfacing the Fortran Spatially distributed Modelling and ASsimilation for Hydrology platform.

https://smash.recover.inrae.fr/

GNU General Public License v3.0

10 stars 5 forks source link

Closed nghi-truyen closed 2 weeks ago

nghi-truyen commented 1 month ago

smash.metrics is deprecated and replaced by smash.evaluation with several changes and enhancements:
- Add possibility to compute multiple metrics at the same time
- Add an argument end_eval to determine the end of computation cost
- Replace end_warmup argument by start_eval argument
- Correct the way to call smash.metrics (deprecated, smash.evaluation now) function including corrections in unit test and documentation
Fix generate baseline when compare empty list with default float64 dtype.

inoelloc commented 4 weeks ago

Pour le Code Checks. Tu peux lancer la commande make check, ca va te fixer ce qu'il faut. Juste ordre des imports

nghi-truyen commented 3 weeks ago

@inoelloc On est bon pour ce PR ?