search

DassHydro / smash

An open source, Python library interfacing the Fortran Spatially distributed Modelling and ASsimilation for Hydrology platform.
https://smash.recover.inrae.fr/
GNU General Public License v3.0
12 stars 6 forks source link

ENH: add the infiltrating rainfall P_s and actual evapotranspiration flux E_s to return_options #276

Closed nghi-truyen closed 1 month ago

nghi-truyen commented 3 months ago

The following two fluxes, which are corrected by the hybrid models, are missing in the return_options:

inoelloc commented 3 months ago

@nghi-truyen Every fluxes that are not inout of elemental subroutine of each module are not returned. We need to change the signature of this subroutine to handle this.

nghi-truyen commented 3 months ago

Yes, for example, we need to change ps and es to intent(out) in the production routine, and then pass them into returns%internal%fluxes in the gr4_time_step routine (and also add make some changes to the Python interface, e.g. _constant.py of course). Does that pose a problem?

inoelloc commented 3 months ago

Yes I'd go for this

nghi-truyen commented 3 months ago

P.S.: I just merged the writing fluxes code into my branch with hybrid models here: https://github.com/nghi-truyen/smash-dev/tree/enh-hybrid-models (I haven't put in a PR for this branch yet because I am waiting for the two previous PRs to be completed, but no pressure at all for you ;))

So I'd rather address this issue after the branch on hybrid models is merged.