DassHydro / smash

An open source, Python library interfacing the Fortran Spatially distributed Modelling and ASsimilation for Hydrology platform.
https://smash.recover.inrae.fr/
GNU General Public License v3.0
12 stars 6 forks source link

MAINT: `cost_options` argument in `smash.optimize_control_info()` could be removed #302

Closed nghi-truyen closed 1 day ago

nghi-truyen commented 1 month ago

The cost_options argument in smash.optimize_control_info() seems to be redundant. However, the one in smash.bayesian_optimize_control_info() is necessary to define both sg0 and sg1 parameters (depending on calibrated gauges).

Note: The two new methods will be added to smash taking exactly the same arguments of smash.optimize_control_info() and smash.bayesian_optimize_control_info() methods. These methods would enable users to retrieve the model object from a control vector solution.