DatBear / Guardians-of-the-Rift-Helper

Shows info about the Guardians of the Rift minigame
BSD 2-Clause "Simplified" License
7 stars 26 forks source link

[Bug] Outline Great Guardian doesn't work until an item is added/removed #45

Open CreativeTechGuy opened 1 year ago

CreativeTechGuy commented 1 year ago

Since a recent update (unclear if this was a Runelite change or a plugin change), the outline of the Great Guardian is broken. The Great Guardian isn't outlined immediately upon returning from an altar. Instead they are only outlined once an item has been first added/removed from the inventory

I believe I've traced it to the exact lines of code involved if that'll help.

When you craft runes, you aren't in the main region so that check is false. But when you arrive back in the main region, the code isn't reevaluated when you change regions and therefore only updates when you have an inventory event.

I'm not sure the solution without testing it, but it seems like if the isInMainRegion check was changed to checkInMinigame() (assuming that function isn't too expensive), that could work. Or there might be another hook which should be used instead for when the region changes.

CreativeTechGuy commented 1 year ago

This same issue also affects inventory talisman highlighting due to the same reason.

otygah commented 9 months ago

I'm still getting this issue :/