DatBear / Guardians-of-the-Rift-Helper

Shows info about the Guardians of the Rift minigame
BSD 2-Clause "Simplified" License
7 stars 26 forks source link

[Bug] Game Loading causing hint arrows to get cleared #57

Open mraware opened 3 months ago

mraware commented 3 months ago

I was doing Brimhaven Agility Arena and I noticed that the official Agility Plugin wasn't properly tracking time between tickets and alerting when ticket is changed and sometimes the hint arrow is vanishing so I can't tell which Ticket Dispenser I should go to. After looking for the bug in the Agility Plugin I noticed everything is tied to the hint arrow moving and realized that the issue was being caused by some other plugin clearing the hint arrows. Hello other plugin!

When loading the reset() method is being called https://github.com/DatBear/Guardians-of-the-Rift-Helper/blob/8d18fc7f72c565ae01aeddcac2480606c6f7aad9/src/main/java/com/datbear/GuardiansOfTheRiftHelperPlugin.java#L372-L376

The reset() method calls client.clearHintArrow() https://github.com/DatBear/Guardians-of-the-Rift-Helper/blob/8d18fc7f72c565ae01aeddcac2480606c6f7aad9/src/main/java/com/datbear/GuardiansOfTheRiftHelperPlugin.java#L427-L435

As a result whenever the game is "Loading" all hint arrows are getting cleared.