search

DatCaptainHorse / MAS-Additions

Additions for Monika After Story
MIT License
20 stars 3 forks source link

Fixed an issue with not booting using current ver. #18

Closed QuadILOP1 closed 2 years ago

QuadILOP1 commented 2 years ago

Line 1-35 indented and fixed to where it would boot with MAS. Was crashing before it would start. Just some indentions to mask functions into different if functions. and, IMO, makes it easier to read.

DatCaptainHorse commented 2 years ago

Wow I didn't expect to see pull requests on this project, thank you this is truly helpful!

DatCaptainHorse commented 2 years ago

Ah.. my morning brain strikes again, didn't notice how the indentation was actually bad, reverted with commit 2b0d7c064aeccd2f99373c65bc503353ccf061a1.

With your indentation changes, "How do I look?" topic doesn't get added to list and topic override doesn't work. if persistent.submods_dathorse_FDAR_date is None: # If not initialized yet, set as yesterday so rest goes smoothly comment here means the persistent variable not being initialized/set. It doesn't control FDAR initialization.

DatCaptainHorse commented 2 years ago

Just wanted to say, don't feel discouraged even though your first PR didn't work out as intended, it's my fault for not commenting things with contributions in mind.

I'd love to get people to help on this project so it's issues can be squashed and things improved, for example the dictionary variable stateMachine that manages FDAR states is bug-prone.