DatL4g / Burning-Series

Watch any series from Burning Series using this app. This is an unofficial Burning Series App
GNU General Public License v3.0
114 stars 7 forks source link

[BUG] multiple issues and requests. #69

Open Slluxx opened 7 months ago

Slluxx commented 7 months ago

1) When casting to a device, you get 2 different quick media "notifications". That takes up space in my notification bar, looks ugly and is confusing (screenshot 1). Your quickmedia bar is better because you can control the progression but i doubt you can hide other apps quick bars. Maybe you can give us the option to remove yours though. Not sure what the best action would be.

2) I somehow managed to get the entire app as floating window instead of the media controls (screenshot 2).

3) When watching a show on my phone, the top ui bar disappears (clock, notification icons and what not), which moves the title of the show into the space of my notch, making it hard to read. The top bar should not disappear in portrait mode.

4) When casting anything, the video is removed, leaving nothing but a blank space since title and progress will hide itself after a few seconds. This left me wondering if my screen is off/locked or active multiple times. I have an oled phone so its literally just pitch black until i click somewhere. Please leave a stillframe so we know that the display is active.

5) When watching a video in portrait mode, there should be quick access buttons for the next and previous episode. That will spare us from going back, clicking the next episode, waiting and then watching - making the process much faster and less disruptive.

6) Currently when you want to select the next episode, you have to click the back button which, when casting, stops the entire cast connection to my TV. It has to be re-established every time. Leaving the cast connection open would speed things up a lot. This goes hand in hand with request 5 to drastically increase the flow.

Screenshot_20240127-012146_Discord Screenshot_20240126-023135_Evolution_X_Launcher

DatL4g commented 7 months ago
  1. You are right I can't change the other notification, on most systems I tested, these notifications were merged, so it's platform dependend.

  2. That's a design descision by Android, can't be changed

  3. It's a bit tricky to find the safe zones of and apply it to legacy views.

  4. The casting feature can't be changed as well

  5. Not planned yet, as it's hard to implement

  6. Going back by gesture or software button works, you just to press twice

Slluxx commented 7 months ago

You are right I can't change the other notification, on most systems I tested, these notifications were merged, so it's platform dependend.

It is but you did not give an answer about the option to disable your media bar. For anyone casting its unnessesary anyway since we can control the shows with our tv remote. Id even argue that it is unnessesary for everyone because even when you are watching on your phone, you are most of the time in the media view anyway. Its not like spotify where its expected to not be in the app.

That's a design descision by Android, can't be changed

You misunderstood me or did not look at the screenshot correctly. I have no problem with the floating window and know that its native but it should only display whatever media is played, not the normal app. Please take a closer look and you will see the "start", "favorite" and "search" bottom bar. This is not expected behavior but a bug.

It's a bit tricky to find the safe zones of and apply it to legacy views.

Just don't hide the android system bar in portrait mode? No need to find any safezones if the content is placed under that bar like in any other view.

The casting feature can't be changed as well

Other apps start the casting process when the app is opened, not in the one view where the media is playing, leaving the connection open and simply giving the SDK the next video to play. The SDK can't be changed but the apps behavior can. it is possible.

Not planned yet, as it's hard to implement

Just add a floating action button in the media view when in portrait mode. Just like with the system bar, you can hide everything in landscape mode, when a user actually wants an immersive experience. When in portrait mode, you can add or simply "not hide" UI elements.

DatL4g commented 7 months ago
  1. Won't be implemented I guess, to much work for a thing that does not appear on all devices and isn't breaking anything.

  2. I did not misunderstand you, the PIP mode can't be disabled after enabling once, that's a design decission by Android.

  3. Safe zones do not only appear at the top, and screen orientation related coding doesn't work since devices nearly ignore this setting.

  4. There are deeper related reasons why that's not implemented in my app this way.

  5. It's not just adding a new button, again there are deeper related issues why this doesn't work at the moment. Plus again orientation focussed programming doesn't really work these days.