Trap-and-bin this - Githubissues

Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io

MIT License

283 stars 86 forks source link

Trap-and-bin this #185

Closed pikesley closed 7 years ago

pikesley commented 8 years ago

Trapping and binning this exception allowed me to actually use this code in a real-world situation. Crucially (maybe), all the specs still pass

coveralls commented 8 years ago

Coverage remained the same at 97.222% when pulling fcbe8ad0ee80a9bf1b9d9d0e9444f01496bb29c1 on baffled-by-csvw into f8fa9e15f4d314aba1970444c4eee22210467530 on master.

pezholio commented 7 years ago

@pikesley What was going on here? Reckon this can be safely merged?

pikesley commented 7 years ago

I have very little recollection of anything that happened pre-Brexit

pikesley commented 7 years ago

I think this is fine to merge