Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io
MIT License
283 stars 86 forks source link

Add row + col to foreign key & duplicate key errors #188

Closed nickzoic closed 7 years ago

nickzoic commented 7 years ago

Improvements to output on foreign key error and duplicate key error:

nickzoic commented 7 years ago

Hi, not sure why it is failing checks, it passes test suite run locally. I haven't written new tests for the specific behaviour I changed though.

pezholio commented 7 years ago

Ah, I think the problem is dependencies. A lot of the dependencies are stopping support for older versions of Ruby, so we need to pin the dependencies to older versions. I'll do this, and then let you know. Once we've done, if you pull Master into your branch and push it, we should have passing tests :+1:

nickzoic commented 7 years ago

No worries, thanks, let me know!

pezholio commented 7 years ago

@nickzoic Sorry for the delay, this should be good to go now

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.003%) to 97.225% when pulling 6939bf19002a1530e9514eac9de5bd5f677ef212 on nickzoic:feature-add-row-col-to-foreign-key-error into f8fa9e15f4d314aba1970444c4eee22210467530 on theodi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.003%) to 97.225% when pulling 6939bf19002a1530e9514eac9de5bd5f677ef212 on nickzoic:feature-add-row-col-to-foreign-key-error into f8fa9e15f4d314aba1970444c4eee22210467530 on theodi:master.

pezholio commented 7 years ago

@nickzoic Actually, you don't need to do anything here. Tests are all good now, as I restarted the build