Closed jamesjefferies closed 7 years ago
Ah, after a bit if digging, I think I'm right in that it is actually the Ruby CSV class which throws the error when parse_line
is called. I think I was confused as LineCSV also has a parse_line
method ;) - so I can only assume that this is a change to how the CSV handles unclosed and stray quotes. In this case, 2.4 considers it a stray quote rather than an unclosed quote.
Hey @jamesjefferies - did you encounter this while attempting to bring CSVlint into Octopub? I ask given the name of your local branch To create a Ruby 2.4 / Rails 5 compatible version of CSVLint
, as it raises a good question of whether this gem needs to be considerate of rails apps its included within
@quadrophobiac yes, that rings a bell - it's a dependency of Octopub and as we were updating Octopub to 2.4/5 I created that branch of CSVlint which was compatible and therefore could be used..
I've "resolved" this in the tests now. I can't make Ruby throw a stray quote error on 2.4, so for now it's in there but pending. The unclosed quote test is improved to make more sense, and works fine.
Checked out the repository. Rspec tests pass on Ruby 2.1.X, 2.2.X and 2.3.X but a test failure happens on 2.4.0 - not sure why yet, will investigate further. Possibly ordering?