search

Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io
MIT License
286 stars 87 forks source link

Ruby 2.4 rails 5.0 compatibility #196

Closed jamesjefferies closed 7 years ago

jamesjefferies commented 7 years ago

This is a Ruby 2.4 / Rails 5.0 compatibility release, removing the constraint on ActiveSupport.

NOTE though that the Ruby 2.4 CSV library appears to behave slightly differently than previous versions. The amended test case demonstrates this. Consequently, these updated tests will fail on Ruby < 2.4.

Maybe the ruby version shouldn't be specified in the codebase, but I've not dug around to work out how to run different versions of an Rspec test depending on which version of Ruby you are using!

This PR updates the travis.yml so it only runs on 2.4 - which I think isn't a great idea either. So do not merge without having a think.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 97.125% when pulling 4d6335869e0801b04082f30d65cd0d10e4647c25 on jamesjefferies:ruby-2.4-rails-5.0-compatibility into 7780c7835614abe300ad8a212b95e79a48fe1460 on theodi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 97.125% when pulling 117c0eab2d86f3124e51827ed6a769d13e5fa1a5 on jamesjefferies:ruby-2.4-rails-5.0-compatibility into 7780c7835614abe300ad8a212b95e79a48fe1460 on theodi:master.

Floppy commented 7 years ago

Merged into #207