Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io
MIT License
286 stars 87 forks source link

Feature request: remove dependency on GPL-2'ed "colorize" gem #214

Closed cobbr2 closed 4 years ago

cobbr2 commented 6 years ago

We (Grand Rounds, www.grandrounds.com) would like to use csvlint in our own commercial application, which is not and should not be FOSS (at least in our opinion). Since we (and AFAICT, the FSF) regard bundling a gem as essentially identical to "linking", we can't use gems that are covered by the full GPL license. Colorize is licensed under GPL-2 .

Desired Behaviour (for improvement suggestions only)

Replace use of Colorize with Rainbow which is covered by the MIT license. I suggest Rainbow because it appears to be nearly call-compatible, while easier to globally disable/enable (so removing almost every test for if $stdout.tty?).

Your Environment

I'm happy to submit a PR for this, working on it.

What would you suggest I use to test cli operation is as good as it was previously? Since the current code tests $stdout.tty?, it appears that testing colors may be a bit hacky.