Replace colorize with rainbow to make licensing consistent.

cobbr2 commented 6 years ago

This PR fixes #214

Changes proposed in this pull request:

Remove 'colorize' and use 'rainbow' as production dependencies
Only enable 'rainbow' if $stdout.tty? to keep behavior the same as it was previously

The first commit uses rainbow/refinements to make the code as similar to the colorize version as possible, but that breaks Ruby-2.0.0 compatibility. Now uses Rainbow's "presenter" style to support all the versions currently configured in Travis.

Using Rainbow introduces a risk for future maintainers: Rainbow colorizes based on a global setting. So if some additional output stream (e.g., a separate warnings output file) were added, and the color refinements were called on it, they would be enabled/disabled based on the same flag as the cli uses.

007 commented 5 years ago

Happy Birthday #215!

cobbr2 commented 5 years ago

Happy New Year, @007 .

Floppy commented 5 years ago

🍰

cobbr2 commented 4 years ago

Happy New Year, @007. Happy 2nd birthday, #215 !

Floppy commented 4 years ago

It's on my todo list to sort out ownership and maintenance of this repo - thanks for the ping to remind me to Just Get It Done. And happy birthday #215 indeed. 🍰

Floppy commented 4 years ago

Data-Liberation-Front / csvlint.rb

Replace colorize with rainbow to make licensing consistent. #215