Test on Ruby 2.5 and 2.6

Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io

MIT License

283 stars 86 forks source link

Test on Ruby 2.5 and 2.6 #223

Closed Domon closed 4 years ago

Domon commented 5 years ago

Context

Currently, there are 38 test cases fail on Ruby 2.5 and 2 failures on Ruby 2.6.

However, it is not obvious from CI.

Change

Test the gem on Ruby 2.5 and 2.6 so that people have better visibility on the failed test cases.

Floppy commented 4 years ago

Interestingly, after updating the Ruby 2.5 patch version to the latest, that works fine. Two failures in 2.6 due to changes in the CSV loading code, I think.

Floppy commented 4 years ago

I wonder if perhaps it would be best to merge in the 2.5 build, then open up a branch for 2.6 support, as that's obviously going to need a bit of work.