Lock activesupport - Githubissues

Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io

MIT License

283 stars 86 forks source link

Lock activesupport #279

Closed rddimon closed 7 months ago

rddimon commented 10 months ago

This PR fixes #280

Changes proposed in this pull request:

Lock version of the activesupport package

rddimon commented 10 months ago

Hi @Floppy Will you be able to help with the lint issues? As I'm not a ruby guy =( Or will it be good to go as is? As I can see lint is not required check

D-system commented 7 months ago

This is a short term solution. We need to extract the the Activesupport::deprecator to conditionally use the proper method.

D-system commented 7 months ago

For the linter issue https://github.com/Data-Liberation-Front/csvlint.rb/pull/285

D-system commented 7 months ago

I needed to specify the compatible version of ActiveSupport for my own PR so I merged your code into my PR (your commit is still labelled as yours)

Floppy commented 7 months ago

The activesupport update has been attempted by Dependabot in #287, so we can attempt to fix the actual deprecation issue in there.