Update syntax for StandardRb (part 1)

Data-Liberation-Front / csvlint.rb

The gem behind http://csvlint.io

MIT License

283 stars 86 forks source link

Update syntax for StandardRb (part 1) #293

Closed D-system closed 5 months ago

D-system commented 5 months ago

Let's fix those syntax recommended by StandardRb as it is the tool used.

I splitting the PRs due to difficulties to review too many files at once. Also some recommendation is more then just code "beauty".

D-system commented 5 months ago

@Floppy can't we remove old Ruby versions? Specially the versions that are not compatible with Rails 7 (meaning Ruby 2.5 and 2.6).

Floppy commented 5 months ago

Yeah, I think we could drop old versions that are EOL (basically anything below 3), with a major version bump.

D-system commented 5 months ago

Ok, great, I will do it. First, I'll update the code from StandardRb as much as possible without changing the ruby compatibilities then it will be a good time to release it (with ActiveSupport 7.1) then change the minimum Ruby version and do the breaking changes.

For now, this PR is good to be merged. If you don't like the revert commit, feel free to "squash and merge" the PR.