search

Data-Oriented-House / PortableBuildTools

Portable VS Build Tools installer
595 stars 19 forks source link

cli doesn't handle invalid values well #12

Closed milnak closed 3 months ago

milnak commented 3 months ago

portablebuildtools.exe cli accept_license msvc='14.40.33807' sdk='10.0.26100.0'

ultimately fails with: w:/dev/PortableBuildTools-master/src/install.odin(1000:37) Index 0 is out of range 0..<0

should do validation and fail fast.

milnak commented 3 months ago

in addition, an invalid msvc version (as shown) doesn't fail.

j-begin commented 3 months ago

This has been fixed.

Thank you.