search

Data2Dynamics / d2d

a modeling environment tailored to parameter estimation in dynamical systems
https://github.com/Data2Dynamics/d2d
57 stars 28 forks source link

Code smell in arLink #139

Open JoepVanlier opened 5 years ago

JoepVanlier commented 5 years ago

There is some code smell in arLink.

There are several arguments for adding temporary data points here specifically for arPPL. The datapoints added here are hardcoded to go into the ppl substruct.

This should really be refactored to use arAddData instead.

Tasks:

  1. Develop test for arPPL.
  2. Refactor arLink and arPPL to separate concerns.