search

Data2Dynamics / d2d

a modeling environment tailored to parameter estimation in dynamical systems
https://github.com/Data2Dynamics/d2d
57 stars 29 forks source link

running doTests on Windows #95

Closed plakrisenko closed 7 years ago

plakrisenko commented 7 years ago

Hello!

It looks like in the file /arFramework3/Examples/doTests.m, in the function doTest, line 90

[~,dir] = system(sprintf('find %s -type d -name "%s"',example_folder,dir));

doesn't work for windows.

I think this should work: if isunix command = sprintf('find %s -type d -name "%s"',example_folder,dir); else command = sprintf('dir "%s" /AD /b /s | findstr /r "%s$"',example_folder,dir); end [~,dir] = system(command);

Probably you know better way of fixing it.

best regards, Polina

araue commented 7 years ago

Hi Polina,

Thanks for reporting this and suggesting a solution. If the fix you propose work on your (Windows) system, please feel free to submit it to the repository.

The software replies on creative solutions from users! ;-)

Cheers, Andreas

On May 15, 2017, at 11:40 AM, plakrisenko notifications@github.com wrote:

Hello!

It looks like in the file /arFramework3/Examples/doTests.m, in the function doTest, line 90

[~,dir] = system(sprintf('find %s -type d -name "%s"',example_folder,dir));

doesn't work for windows.

I think this should work: if isunix command = sprintf('find %s -type d -name "%s"',example_folder,dir); else command = sprintf('dir "%s" /AD /b /s | findstr /r "%s$"',example_folder,dir); end [~,dir] = system(command);

Probably you know better way of fixing it.

best regards, Polina

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Data2Dynamics/d2d/issues/95, or mute the thread https://github.com/notifications/unsubscribe-auth/APujFkzzeaKgYRyUNaoZDS4GdnmUjob3ks5r6HHwgaJpZM4NbUJf.

JoepVanlier commented 7 years ago

I've pulled your suggestion into the repository, Polina. Thank you for your contribution!

Best, Joep.

plakrisenko commented 7 years ago

Thank you very much for the fix!

We couldn't make the toolbox work on Windows though (both Windows 7 and 10). Unfortunately, I cannot explain properly what was the last problem as I don't have Windows myself. It was something mex compiler related. So, we've installed ubuntu in the end)