Closed cduvallet closed 7 years ago
@cduvallet! The data summary and data dictionary are SO helpful! I've asked Matt or Daniela to review it because I'm not a Python user, but whether or not the data relates to what we're doing immediately, having all this documented so well is fantastic. Thank you!
I can review this today, unless @mattgawarecki is on it already.
I can also check tonight if these classifications work for the Part D data that I've been playing around with.
@dhuppenkothen I made the changes you recommended, it's much nicer now. I wasn't sure of the best way to interface with read_data.py
(so I just re-wrote the download data wrapper...)
Also, it seems that there are currently two ways we're keeping track of, downloading, and tidying data:
script/read_data.py
script has individual functions for each of the datasets that downloads and tidies, anddata/
folder has individual data dictionaries and corresponding tidying scripts, one for each individual dataset.From what I understood from @mattgawarecki, I think we're going with option 2? But let me know if not, and I can incorporate this into the read_data.py
script.
@cduvallet I'll let @dhuppenkothen speak to read_data.py
, but just wanted to jump in and say we had a long discussion today about repo organization, and I just submitted a PR to reflect the updated file structure. Once we get that finalized we'll clean up all the documentation, but the idea will be to have a dictionary (md
) in /datadictionaries
, and tidying scripts in (in your case) /python/datawrangling/[subfolders if you need it]
. Not sure if that answers all your questions, but hopefully helps! Thanks so much for bearing with us while we get more streamlined - it'll help tremendously in the long run.
Hey @cduvallet and @dhuppenkothen! Just checking in on the status of this PR. No rush intended on my end, just wanted to make sure there isn't anything blocking either of you that we need to take care of administratively.
@jenniferthompson Nope, I was just traveling this weekend so haven't gotten around to finalizing this. Will update if I need anything from y'all! :)
Okay, I think we should be ready to merge! @jenniferthompson double-check and let me know if anything needs to change?
@cduvallet The data-dictionaries branch looks great! Would you mind pushing that to your master branch so it'll show up on master here? I think that should do it!
@dhuppenkothen did you have any further suggestions on the Python code?
@jenniferthompson I think I did it! Should be ready to merge if @dhuppenkothen doesn't have other comments.
Looks good to me!
Oops. I'll get this into master
instead of data-dictionaries
.
Continuing on issue #14, finalize the USP Drug Classification data dictionary, etc. Taw and tidy data are on data.world.
This data may or may not be useful - it has non-Medicare Part D medications and their respective classes/categories. The classes and categories are pretty self-explanatory (e.g.
Antidepressants
,Antiparkinson Agents
,Sleep Disorder Agents
) and can likely easily be tied to usage (depending on how we decide to define usage...).Some follow up tasks, if we decide to use this data: