Data4Democracy / internal-displacement

Studying news events and internal displacement.
43 stars 27 forks source link

Database access #123

Closed WanderingStar closed 7 years ago

WanderingStar commented 7 years ago

move schema.sql into localdb directory load schema.sql when initializing database consolidate to one DB user for both jupyter and node remove initialization code from python add an example of database use in notebook DatabaseExample add an example of database connection in node src/db.js added some documentation

WanderingStar commented 7 years ago

This changeset sets up the database schema entirely from within the localdb setup. Connection information is passed to both the python and node containers through docker.env. Examples of getting the connection information from the environment in both setups.

wwymak commented 7 years ago

looks fine to me-- but I am not that experienced with Postgres db schemas so I'll leave the proper review to @simonb83

WanderingStar commented 7 years ago

Thanks for the review, merged.