search

DataAction / AdoNetCore.AseClient

AdoNetCore.AseClient - a .NET Core DB Provider for SAP ASE
Apache License 2.0
106 stars 44 forks source link

Handle empty new character set in EnvChangeTokenHandler #111

Closed driseley closed 5 years ago

driseley commented 5 years ago

Proposed fix for #110

driseley commented 5 years ago

@c-j-hughes Thanks for the review. I have added some unit tests for the EnvChangeTokenHandler class, and in the process of doing so realised that I had missed that the existing encoding lookup should be done with the resolved new charset, not the change value from the token, so have amended the code to address that.

If you are happy with this - would it possible to get a NuGet release of the driver with this fix and the PR for #108 (when it's ready), as we are currently dependent on a local build with these changes in them? Many thanks.

driseley commented 5 years ago

@c-j-hughes , @senseibaka - Many thanks for the release - that has helped us a lot (we were running a significant project risk with the local driver build)!