DataAction / AdoNetCore.AseClient

AdoNetCore.AseClient - a .NET Core DB Provider for SAP ASE
Apache License 2.0
106 stars 44 forks source link

Expose AseCommand empty parameter constructor #67

Closed beppler closed 6 years ago

beppler commented 6 years ago

The AseParameter classe is exposing only the overload that receives an AseConnection parameter that is needed if you want to use the provider with NHibernate.

Trying to use this overload, but passing null throws a NullRefenceException on this line.

Can you expose the empty parameter constructor (it is internal now) and make the NamedParamters on this line property true in this case?

senseibaka commented 6 years ago

Thanks for raising this.

Parameter-less constructor Agreed, the reference driver exposes this, so in the interests of drop-in replacement we should too.

In addition, the reference driver exposes these constructors:

So I will go ahead and add these as well.

NamedParameters Yes, I agree this should default to true; it's a sensible setting to have turned on. Also, we don't yet support NamedParameters = false, so defaulting to false is a bit silly, isn't it?

beppler commented 6 years ago

Wow, that is fast, thanks!