DataAction / AdoNetCore.AseClient

AdoNetCore.AseClient - a .NET Core DB Provider for SAP ASE
Apache License 2.0
106 stars 44 forks source link

Separate AseDbType from DbType #80

Closed senseibaka closed 6 years ago

senseibaka commented 6 years ago

The AseDbType started off being an enum whose values were informed by (pinned to) those of DbType, which lead to some enum values being the same/indistinguishable (like Image vs Binary).

This generally isn't a big deal, but it makes it harder for callers to specify an exact AseDbType and see the behaviour they're expecting (generally in edge cases, admittedly).

So, this change seeks to right that wrong, and at the same time address issues #59 and #62 .

senseibaka commented 6 years ago

Note: don't merge just yet, I might be adding a few more tests/fixes

senseibaka commented 6 years ago

So, this PR now fixes issues:

senseibaka commented 6 years ago

Yep, I reckon it's ready for review / merge