search

DataAction / AdoNetCore.AseClient

AdoNetCore.AseClient - a .NET Core DB Provider for SAP ASE
Apache License 2.0
108 stars 45 forks source link

EnvChangeTokenHandler can prevent connections if Encoding.GetEncoding() fails #90

Closed senseibaka closed 6 years ago

senseibaka commented 6 years ago

Currently, EnvChangeTokenHandler.CharsetMap is a dictionary of string -> Encoding.

If Encoding.GetEncoding cannot locate the specified encoding scheme (regardless of if it will be used), then construction of the dictionary fails, preventing driver usage.

To allow for more obscure character encodings to be added without breaking existing function, this dictionary should change to string -> Func<Encoding>