DataBiosphere / azul

Metadata indexer and query service used for AnVIL, HCA, LungMAP, and CGP
Apache License 2.0
7 stars 2 forks source link

Elasticsearch base image and link in `upgrade` issues don't match #5821

Closed hannes-ucsc closed 9 months ago

hannes-ucsc commented 10 months ago

https://github.com/DataBiosphere/azul/blob/7c7e4af9920092676079fa0fd3e1ba0c016bf6a4/.github/ISSUE_TEMPLATE/upgrade.md?plain=1#L18

https://github.com/DataBiosphere/azul-docker-elasticsearch/blob/06505bd020664023750949dd80dcc556d1a1808c/Dockerfile#L3

The link should either be https://www.docker.elastic.co/r/elasticsearch or we should change the base image to the one from DockerHub. The former is hard to navigate (one has to skip several pages before getting to the 7.x tags) while the latter receives updated images with a delay. I'm leaning towards the latter. If we do that we should consider also switching the Kibana image from docker.elastic.co to hub.docker.com.

hannes-ucsc commented 10 months ago

Security review: This switches the to the Elasticsearch image from DockerHub rather than Elastic's own registry. The image is still an official image …

image

… so I trust it as much as I do trust the image published by Elastic.

hannes-ucsc commented 9 months ago

Commit https://github.com/DataBiosphere/azul-docker-elasticsearch/commit/062331022c502ce3293f4682d6584826f165f9a6 addressed this.