Open dsotirho-ucsc opened 5 months ago
Index: terraform/gitlab/gitlab.tf.json.template.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/terraform/gitlab/gitlab.tf.json.template.py b/terraform/gitlab/gitlab.tf.json.template.py
--- a/terraform/gitlab/gitlab.tf.json.template.py (revision f1a3d58efe03021f754f89a1f8f03484574e3aaf)
+++ b/terraform/gitlab/gitlab.tf.json.template.py (date 1712694300553)
@@ -345,7 +345,10 @@
'edu-ucsc-gi-azul-*',
'*.azul.data.humancellatlas.org',
]
- )
+ ) + [
+ f'amazon-ssm-packages-{aws.region_name}',
+ f'aws-ssm-document-attachments-{aws.region_name}'
+ ]
)
},
@@ -949,7 +952,9 @@
's3:HeadObject'
],
'resources': [
+ f'arn:aws:s3:::amazon-ssm-packages-{aws.region_name}',
f'arn:aws:s3:::amazon-ssm-packages-{aws.region_name}/*',
+ f'arn:aws:s3:::aws-ssm-document-attachments-{aws.region_name}',
f'arn:aws:s3:::aws-ssm-document-attachments-{aws.region_name}/*'
]
}
~For demo, show absence of matching trail log events for one week after this lands in a main deployment.~
https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent-minimum-s3-permissions.html
Assignee to chase PR with another one that mentions all buckets as documented above.
For demo, show absence of matching log events for one week after this lands in a main deployment.
@hannes-ucsc: "We are still getting these false alarms (#6208) and we are unsure as to why. The policies seem correct. Ultimately, we can disable this type of alarm as per latest FedRamp guidance. No demo necessary."
Originally posted on another issue https://github.com/DataBiosphere/azul/issues/6134#issuecomment-2166703120:
From the spike experiments for #6134 it appears that AccessDenied requests occur in the following cases: When a newly created instance first starts up (two AccessDenied requests), when a new version of the SSM agent is available and automatically installed by the agent (new versions are checked twice daily, the uninstallation of an old version incurs two AccessDenied requests, the installation of the new version incurs another two). We typically observe one SSM updated per week, so we expect four false AccessDenied alarms. If new versions are released more frequently, we could observe up to eight false AccessDenied alarms (2 * (2 + 2)).
Assignee to try s3:* in the IAM policy.
Originally posted on another issue https://github.com/DataBiosphere/azul/issues/6134#issuecomment-2183340103:
Assignee to draft a AWS support request on Google Docs.
AWS Support case has been created.
Assignee to monitor AWS Support ticket and follow up if necessary.
AWS Support responded, they've mentioned that this is a known issued and that there's nothing we could do to prevent it. They also said that they've urge the service team responsible for this to look into it and that they'll keep us posted with the details.
Followed up with some questions, awaiting response.
Note that this was already closed with a fix in stable, but the fix was ineffective so we went back to AWS Support. Spike to continue to monitor the AWS Support ticket.
@hannes-ucsc: "AWS responded stating that they are working on a fix, but can't release an ETA for it. Assignee to continue to monitor the support ticket."
AWS responded,
Sadly, I have not yet received an update regarding the fix for this issue. I have escalated the matter internally in the hope that we can drive this to resolution soonest.
I apologise for the delay here and appreciate your continued patience.
still waiting for an upstream resolution.
Assignee to periodically check with AWS Support.