Closed dsotirho-ucsc closed 1 month ago
Proposed fix
Index: terraform/gitlab/gitlab.tf.json.template.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/terraform/gitlab/gitlab.tf.json.template.py b/terraform/gitlab/gitlab.tf.json.template.py
--- a/terraform/gitlab/gitlab.tf.json.template.py (revision fe8cec390f8d7ef81a63e38a580d4a98b72309f4)
+++ b/terraform/gitlab/gitlab.tf.json.template.py (date 1714586652595)
@@ -1126,7 +1126,7 @@
from_port=0,
to_port=0),
vpc.security_rule(description='ICMP for PMTUD',
- idr_blocks=[all_ipv4],
+ cidr_blocks=[all_ipv4],
protocol='icmp',
from_port=3, # Destination Unreachable
to_port=4) # Fragmentation required DF-flag set
For demo, show the rule that was missing. Deploy the gitlab
component of any main deployment twice in succession and show that the plan is empty for both.
The
azul-gitlab-alb
security group should have two egress rules as defined by the Terraform config (gitlab.tf.json), however deploying this configuration fails to apply the change, despite TF reporting a successful modification of the resource.