Promotion 2024-11-05 prod (#6683)

achave11-ucsc commented 2 weeks ago

Connected issue: #6683

Notes

These changes require manual deletion of the pilot1 catalog

Checklist

Author

[x] Target branch is prod
[x] Name of PR branch matches promotions/yyyy-mm-dd-prod
[x] On ZenHub, PR is connected to the promotion issue it resolves
[x] PR description links to connected issue
[x] Title of connected issue matches Promotion yyyy-mm-dd
[x] PR title starts with title of connected issue followed by prod
[x] PR title references the connected issue

Author (reindex, API changes)

[x] This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
[x] This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod _{or requires a full reindex or is not labeledreindex:prod}

Author (upgrading deployments)

[x] This PR is labeled upgrade _{or does not require upgrading deployments}
[x] This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
[x] This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
[x] This PR is labeled deploy:runner _{or does not require deploying the runner image}

System administrator (after approval)

[x] Actually approved the PR
[x] Labeled PR as no sandbox
[x] Moved connected issue to Approved column
[x] PR is assigned to only the operator

Operator (before pushing merge the commit)

[x] Pushed PR branch to GitHub
[x] Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply _{or this PR is not labeled deploy:shared}
[x] Made a backup of the GitLab data volume in prod (see operator manual for details) _{or this PR is not labeled backup:gitlab}
[x] Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
[x] Checked the items in the next section _{or this PR is labeled deploy:gitlab}
[x] PR is assigned to only the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator

[x] Background migrations for prod.gitlab are complete _{or this PR is not labeled deploy:gitlab}
[x] PR is assigned to only the operator

Operator (before pushing merge the commit)

[x] Ran _select prod.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
[x] The title of the merge commit starts with the title of this PR
[x] Added PR # reference to merge commit title
[x] Collected commit title tags in merge commit title _{but excluded any p tags}
[x] Pushed merge commit to GitHub

Operator (after pushing the merge commit)

[x] Pushed merge commit to GitLab prod
[x] Build passes on GitLab prod
[x] Reviewed build logs for anomalies on GitLab prod
[x] Deleted PR branch from GitHub
[x] Moved connected issue to Merged stable column on ZenHub
[x] Moved promoted issues from Merged lower to Merged stable column on ZenHub
[x] Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

[x] Deindexed all unreferenced catalogs in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
[x] Deindexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
[x] Indexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
[x] Started reindex in prod _{or this PR does not require reindexing prod}
[x] Checked for, triaged and possibly requeued messages in both fail queues in prod _{or this PR does not require reindexing prod}
[x] Emptied fail queues in prod _{or this PR does not require reindexing prod}

Operator

[x] PR is assigned to only the system administrator

System administrator

[x] Removed unused image tags from pycharm image on DockerHub _{or this promotion does not alter references to that image}
[x] Removed unused image tags from elasticsearch image on DockerHub _{or this promotion does not alter references to that image}
[x] Removed unused image tags from bigquery_emulator image on DockerHub _{or this promotion does not alter references to that image}
[x] PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

achave11-ucsc commented 2 weeks ago

I mock-merged the feature branch to prod via SmartGit, without any conflicts.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (201b89c) to head (285953d). Report is 48 commits behind head on prod.

Files with missing lines	Patch %	Lines
test/integration_test.py	0.00%	11 Missing :warning:
src/azul/plugins/repository/tdr_anvil/__init__.py	91.66%	3 Missing :warning:
src/azul/indexer/index_service.py	94.44%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## prod #6686 +/- ## ======================================= Coverage 85.34% 85.35% ======================================= Files 155 155 Lines 20782 20779 -3 ======================================= - Hits 17736 17735 -1 + Misses 3046 3044 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 2 weeks ago

coverage: 85.368% (+0.007%) from 85.361% when pulling 285953df130e32c623a744112036c8f6c6a74e9e on promotions/2024-11-05-prod into 201b89ca6dff9f364cc0423e28ff3c3da86bb95f on prod.

DataBiosphere / azul